Asynchronously get ShaderModule creation result and compilation info - #25352
Open
beicause wants to merge 11 commits into
Open
Asynchronously get ShaderModule creation result and compilation info#25352beicause wants to merge 11 commits into
ShaderModule creation result and compilation info#25352beicause wants to merge 11 commits into
Conversation
JaySpruce
added
C-Bug
beicause
added
the
S-Blocked
beicause
force-pushed
the
async-shader-load
branch
from
August 11, 2026 07:31
431a008 to
635830a
Compare
beicause
removed
the
S-Blocked
Member
Author
|
Unblocked by wgpu v30.0.1 (gfx-rs/wgpu#10105) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #25342
Solution
Refactor
ShaderCacheto make it only holds processed shader source instead ofwgpu::ShaderModuleand makeload_moduleasync.Testing
Tested
shader_materialwith an invalid shader on native withfile_watcherhot-reloading and on web.Note: blocked by gfx-rs/wgpu#10039. Currently panics on webgpu due to wgpu
popErrorScopebug.